Merged
Conversation
…image view from playQueue visible
Closed
Collaborator
|
Confirmed! Thanks a lot! So instead of those 3 blocks of code you made a |
opusforlife2
added
bug
5 tasks
Stypox
approved these changes
Oct 2, 2020
Member
Stypox
left a comment
Stypox
left a comment
There was a problem hiding this comment.
The code looks good to me, thank you :-D
TobiGr
approved these changes
Oct 2, 2020
Collaborator
|
You approved these changes after merging as well? You reeeeeally like the code, it seems. :P |
ShareASmile
added a commit
to ShareASmile/NewPipe-Legacy-Revo
that referenced
this pull request
Jun 16, 2024
reorder the Control Elements of the background player (putting the Title down) TeamNewPipe/NewPipe#6824 Fixes: TeamNewPipe/NewPipe#6788 TeamNewPipe/NewPipe#2931 new icons in background player by avently commit made image view from playQueue visible by avently in commit TeamNewPipe/NewPipe@dd726fa#diff-EFCAA05775EEBAE5D5E7D3DD8FB04196 from TeamNewPipe/NewPipe#4360 Co-Authored-By: Stanislav Dmitrenko <7953703+avently@users.noreply.github.com> Co-Authored-By: wb9688 <46277131+wb9688@users.noreply.github.com> Co-Authored-By: phigjm <39876427+phigjm@users.noreply.github.com>
5 tasks
ShareASmile
added a commit
to ShareASmile/JustPipe
that referenced
this pull request
Jun 16, 2024
Reorder the Control Elements of the background player (putting the Title down) TeamNewPipe/NewPipe#6824 Fixes: TeamNewPipe/NewPipe#6788 TeamNewPipe/NewPipe#2931 new icons in background player by avently commit in v0.20.0 made image view from playQueue visible by avently in commit TeamNewPipe/NewPipe@dd726fa#diff-EFCAA05775EEBAE5D5E7D3DD8FB04196 from TeamNewPipe/NewPipe#4360 Co-Authored-By: phigjm <39876427+phigjm@users.noreply.github.com> Co-Authored-By: Stanislav Dmitrenko <7953703+avently@users.noreply.github.com>
ShareASmile
added a commit
to ShareASmile/NewPipe-Legacy-Revo
that referenced
this pull request
Jul 14, 2024
reorder the Control Elements of the background player (putting the Title down) TeamNewPipe/NewPipe#6824 Fixes: TeamNewPipe/NewPipe#6788 TeamNewPipe/NewPipe#2931 new icons in background player by avently commit made image view from playQueue visible by avently in commit TeamNewPipe/NewPipe@dd726fa#diff-EFCAA05775EEBAE5D5E7D3DD8FB04196 from TeamNewPipe/NewPipe#4360 Co-Authored-By: Stanislav Dmitrenko <7953703+avently@users.noreply.github.com> Co-Authored-By: wb9688 <46277131+wb9688@users.noreply.github.com> Co-Authored-By: phigjm <39876427+phigjm@users.noreply.github.com>
ShareASmile
added a commit
to ShareASmile/NewPipe-Legacy-Revo
that referenced
this pull request
Jul 14, 2024
reorder the Control Elements of the background player (putting the Title down) TeamNewPipe/NewPipe#6824 Fixes: TeamNewPipe/NewPipe#6788 TeamNewPipe/NewPipe#2931 new icons in background player by avently commit made image view from playQueue visible by avently in commit TeamNewPipe/NewPipe@dd726fa#diff-EFCAA05775EEBAE5D5E7D3DD8FB04196 from TeamNewPipe/NewPipe#4360 Co-Authored-By: Stanislav Dmitrenko <7953703+avently@users.noreply.github.com> Co-Authored-By: wb9688 <46277131+wb9688@users.noreply.github.com> Co-Authored-By: phigjm <39876427+phigjm@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Overlays were off-centered before this PR. By overlays I mean volume slider, brightness slider, loading icon, etc. Now it's fixed.
Also excluded play/prev/next buttons from swipe interception so now it's not possible to drag them up/down with expectation to drag the whole player.
If you'll find any issue, please, fix it yourself or just drop the PR because waiting of the fix from my side will take months. Thank you for understanding.
P.s. so many changes in player.xml in diff view but actually it's just the overlays were included into top level relativelayout to be able to position them via one assigment of paddings. For review it's easier to open previous player.xml and new player.xml side-by-side.
Fixes the following issue(s)
#4332 (comment)
Testing apk
overlays.zip
Agreement